Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fix out-of-tree stringreplace invocations #39567

Merged
merged 1 commit into from
Feb 8, 2021
Merged

[build] Fix out-of-tree stringreplace invocations #39567

merged 1 commit into from
Feb 8, 2021

Conversation

staticfloat
Copy link
Member

Because we now store these strings in libjulia-internal, we need to
call stringreplace on that library instead of libjulia.

@nalimilan with this change I am now able to complete an out-of-tree build (with a different libdir layout) with the following invocation:

prefix=/tmp/outoftree/install
build_prefix=/tmp/outoftree/build
rm -rf /tmp/outoftree
make -j30 prefix=${prefix} libdir=${prefix}/lib64 build_prefix=${build_prefix} install

@staticfloat
[build] Fix out-of-tree stringreplace invocations
68929b7 
Because we now store these strings in `libjulia-internal`, we need to
call `stringreplace` on that library instead of `libjulia`.
@staticfloat staticfloat mentioned this pull request Feb 8, 2021
Closed
@vchuravy vchuravy added this to the 1.6 blockers milestone Feb 8, 2021
@vchuravy vchuravy added the backport 1.6 Change should be backported to release-1.6 label Feb 8, 2021
@vtjnash vtjnash merged commit 4c5d62b into master Feb 8, 2021
@vtjnash vtjnash deleted the sf/outoftree_fixes branch February 8, 2021 20:23
KristofferC pushed a commit that referenced this pull request Feb 11, 2021
@staticfloat @KristofferC
[build] Fix out-of-tree stringreplace invocations (#39567)
6ebd612 
Because we now store these strings in `libjulia-internal`, we need to
call `stringreplace` on that library instead of `libjulia`.

(cherry picked from commit 4c5d62b)
@KristofferC KristofferC mentioned this pull request Feb 11, 2021
Merged
52 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@staticfloat @ElOceanografo
[build] Fix out-of-tree stringreplace invocations (JuliaLang#39567)
cdb1d2e 
Because we now store these strings in `libjulia-internal`, we need to
call `stringreplace` on that library instead of `libjulia`.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@staticfloat @antoine-levitt
[build] Fix out-of-tree stringreplace invocations (JuliaLang#39567)
f497da8 
Because we now store these strings in `libjulia-internal`, we need to
call `stringreplace` on that library instead of `libjulia`.
staticfloat added a commit that referenced this pull request Dec 23, 2022
@staticfloat
[build] Fix out-of-tree stringreplace invocations (#39567)
c651aa5 
Because we now store these strings in `libjulia-internal`, we need to
call `stringreplace` on that library instead of `libjulia`.

(cherry picked from commit 4c5d62b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@staticfloat @vchuravy @vtjnash @KristofferC