faster, more accurate log2, log10 #39556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
force-pushed
the
better-logb
branch
from
ab7f3cf
to
2535c39
Compare
JeffBezanson
approved these changes
Feb 11, 2021
thchr
reviewed
Feb 12, 2021
|
Anyone have objections to merging this? |
3 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* faster, more accurate log2, log10 * fix error message for negative numbers * fix rebase * Maybe fix doctest for domainerror * Fix accidental change * don't use metaprogramming * fix typo
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* faster, more accurate log2, log10 * fix error message for negative numbers * fix rebase * Maybe fix doctest for domainerror * Fix accidental change * don't use metaprogramming * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses our existing very good
logimplementation forlog2andlog10. This both reduces error, and increases speed forFloat32andFloat64. There is no impact onlog(other than a pretty minor performance regression forFloat64). I think I can solve the regression fairly easily, so I'm pushing it now so it can be reviewed (and I can see if CI passes)