-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve str macro doc help #39110
improve str macro doc help #39110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! :) thanks for the PR!
1dd250f
to
f425ce7
Compare
Some of your tests are failing. Also, it would help if you updated the description comment on this PR with an indication of what this changes, and included a before/after example output from the help system. |
Ah, the failing test should be easy to fix. I copied this from the buildbot links above: Error in testset REPL:
Test Failed at /Users/julia/buildbot/worker-tabularasa/tester_macos64/build/share/julia/stdlib/v1.7/REPL/test/replcompletions.jl:10
Expression: (REPL.doc_completions(i))[1] == i
Evaluated: "var\"\"" == "@var_str" And here's the test it's referring to: julia/stdlib/REPL/test/replcompletions.jl Lines 8 to 12 in f425ce7
That last test will fail, since when you ask for @test i ∈ REPL.doc_completions(i) And you might also want to add |
what does this mean? |
Let's rebase this to prepare for merging. |
sorry for my looooong delay. i think that i must have misunderstood something - my concern is addressed. ✅ |
Merge? |
1 similar comment
Merge? |
back port 1.8? |
@@ -720,7 +720,19 @@ accessible(mod::Module) = | |||
map(names, moduleusings(mod))...; | |||
collect(keys(Base.Docs.keywords))] |> unique |> filtervalid | |||
|
|||
doc_completions(name) = fuzzysort(name, accessible(Main)) | |||
function doc_completions(name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, this line had a trailing whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
close #38334
before:
after: