increase RELOC_TAG_OFFSET to handle larger system images
#37613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea how much does a compile all sysimg increase the size/required offset by? |
|
Can we get an explicit error when a relocation would overflow the new limit, so we don't have to diagnose it by rr trace? |
add an error check that the max size is not exceeded
JeffBezanson
force-pushed
the
jb/reloctagbits
branch
from
e684386 to
6134970
Compare
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2020
add an error check that the max size is not exceeded (cherry picked from commit 5f55b97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently very large system images can crash during loading due to overflowing the allowed range of relocation offsets. We currently use 7 RefTags, so we might as well just increase the number of bits available for now.