Remove some references to build time environment from sysimg #36582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only issue I see with this is that generate_precompile is optional. |
|
Doing this in |
All of these are always re-populated at load time and does not need to be in sysimg. Similar to #36536.
yuyichao
force-pushed
the
yyc/clear-sysimg
branch
from
2a1fde1
to
b02dcad
Compare
|
Should be cleared before generate_precompile as well now. |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…ng#36582) All of these are always re-populated at load time and does not need to be in sysimg. Similar to JuliaLang#36536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these are always re-populated at load time and
does not need to be in sysimg.
Similar to #36536.
I'm also carrying more patches to remove all build time path in the binary for a more reprodicuble build as well as being much more friendly to gdb by default similar to the
-f*-prefix-mapGCC options. Those patches are much dirtier currently though....