Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some references to build time environment from sysimg #36582

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Jul 8, 2020

All of these are always re-populated at load time and
does not need to be in sysimg.

Similar to #36536.

I'm also carrying more patches to remove all build time path in the binary for a more reprodicuble build as well as being much more friendly to gdb by default similar to the -f*-prefix-map GCC options. Those patches are much dirtier currently though....

@JeffBezanson
Copy link
Member

The only issue I see with this is that generate_precompile is optional.

@yuyichao
Copy link
Contributor Author

yuyichao commented Jul 8, 2020

Doing this in sysimg.jl is also possible, but then Sys.BINDIR and Sys.STDLIB, both contains reference to build dir, would need to be repopulated before calling this (e.g. by calling Sys.__init__()). The current patch is good enough for my case but I can try making it more general...

All of these are always re-populated at load time and does not need to be in sysimg.

Similar to #36536.
@yuyichao
Copy link
Contributor Author

yuyichao commented Jul 8, 2020

Should be cleared before generate_precompile as well now.

@yuyichao yuyichao merged commit e6f13e9 into master Jul 19, 2020
@yuyichao yuyichao deleted the yyc/clear-sysimg branch July 19, 2020 13:41
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
…ng#36582)

All of these are always re-populated at load time and does not need to be in sysimg.

Similar to JuliaLang#36536.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants