Use proper forward edges in incremental serializer #35188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding_deleted Incremental method deletion is now likely more possible to handle, as well as delayed validation is probably too. And the max_world_mask argument and design is now also unnecessary.
vtjnash
force-pushed
the
jn/proper_edges
branch
from
e0a036e
to
0a97d4a
Compare
vtjnash
added a commit
that referenced
this pull request
Apr 3, 2020
The `valid` parameter was initialized wrong, leading to no edges every being saved.
vtjnash
added a commit
that referenced
this pull request
Apr 3, 2020
The `valid` parameter was initialized wrong, leading to no edges ever being saved.
vtjnash
added a commit
that referenced
this pull request
Apr 3, 2020
The `valid` parameter was initialized wrong, leading to no edges every being saved.
vtjnash
added a commit
that referenced
this pull request
Apr 3, 2020
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
…ding_deleted (JuliaLang#35188) Incremental method deletion is now likely more possible to handle, as well as delayed validation is probably too. And the max_world_mask argument and design is now also unnecessary.
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
The `valid` parameter was initialized wrong, leading to no edges ever being saved.
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
…ding_deleted (JuliaLang#35188) Incremental method deletion is now likely more possible to handle, as well as delayed validation is probably too. And the max_world_mask argument and design is now also unnecessary.
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
The `valid` parameter was initialized wrong, leading to no edges ever being saved.
ztultrebor
pushed a commit
to ztultrebor/julia
that referenced
this pull request
Apr 17, 2020
The `valid` parameter was initialized wrong, leading to no edges ever being saved.
staticfloat
pushed a commit
that referenced
this pull request
Apr 21, 2020
…ding_deleted (#35188) Incremental method deletion is now likely more possible to handle, as well as delayed validation is probably too. And the max_world_mask argument and design is now also unnecessary.
staticfloat
pushed a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us eliminate the special support for deleted methods, and thus eventually possibly letting us actually implement support for incrementally deleting methods.