Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add findall(char, str) and count(char, str) #35137

Closed
wants to merge 1 commit into from
Closed

add findall(char, str) and count(char, str) #35137

wants to merge 1 commit into from

Conversation

bicycle1885
Copy link
Member

Since findfirst(char, string) works, why don't we add findall(char, string) and count(char, string)?

@ararslan ararslan added needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change strings "Strings!" labels Mar 17, 2020
@StefanKarpinski
Copy link
Member

Looks good to me aside from the need for compat and news.

@bicycle1885
Copy link
Member Author

This looks being superseded by #38675.

@bicycle1885 bicycle1885 deleted the char-findall-count branch February 15, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bicycle1885 @StefanKarpinski @ararslan