Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support git credential helper resetting #35064

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Support git credential helper resetting #35064

merged 1 commit into from
Mar 16, 2020

Conversation

omus
Copy link
Member

@omus omus commented Mar 10, 2020

Due to libgit2 fixing an issue with iterator ordering and Julia now updating to a libgit2 release including that fix we now remove this fail safe.

@omus omus added libgit2 The libgit2 library or the LibGit2 stdlib module bugfix This change fixes an existing bug backport 1.3 labels Mar 10, 2020
@omus
Copy link
Member Author

omus commented Mar 10, 2020

I'll note I added the "backport 1.3" label as this change should apply cleanly since the prerequisite #32806 has already been backported: #32973

@omus
Copy link
Member Author

omus commented Mar 13, 2020

CI failures appear to be unrelated

@omus omus requested a review from ararslan March 16, 2020 14:40
@omus
Copy link
Member Author

omus commented Mar 16, 2020

@ararslan could you review? I know everyone seems scared of LibGit2 changes but this one should be pretty easy to review

ararslan
ararslan approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. I assume the macOS failure is unrelated.

@omus omus closed this Mar 16, 2020
@omus omus reopened this Mar 16, 2020
@omus omus merged commit 0f1b119 into master Mar 16, 2020
@omus omus deleted the cv/cred-helper-reset branch March 16, 2020 19:44
@omus
Copy link
Member Author

omus commented Mar 16, 2020

Accidentally closed the PR instead of merging...

KristofferC pushed a commit that referenced this pull request Mar 23, 2020
@omus @KristofferC
Support git config credential resetting (#35064)
f1593e1 
(cherry picked from commit 0f1b119)
@KristofferC KristofferC mentioned this pull request Mar 23, 2020
Merged
27 tasks
oxinabox pushed a commit to oxinabox/julia that referenced this pull request Apr 8, 2020
@omus @oxinabox
Support git config credential resetting (JuliaLang#35064)
3fd1778
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
@omus @ravibitsgoa
Support git config credential resetting (JuliaLang#35064)
aaab877
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@omus @KristofferC
Support git config credential resetting (#35064)
b3eb17a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omus @ararslan @KristofferC @fredrikekre