Revert "add readline(::AbstractCmd)" #34958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 570f6d9.
|
How did this cause win64 to fail? |
|
The test keeps a BusyBox command running and doesn't wait for it to exit. On win64 we delete BusyBox at the end of that testset which fails if the command is still running. |
|
Ah, so we need to terminate the process before returning the line string. |
|
Yes, that would be one valid solution (which I think would be ok).
…On Mon, Mar 2, 2020, 02:10 Kenta Sato ***@***.***> wrote:
Ah, so we need to terminate the process before returning the line string.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#34958?email_source=notifications&email_token=AAJ3LF2PI4QYI4KQU5TCTOLRFNLVPA5CNFSM4K7JSPE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENOFK7I#issuecomment-593253757>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ3LFZNQH4ONUNCISFGQKTRFNLVPANCNFSM4K7JSPEQ>
.
|
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
This reverts commit 570f6d9.
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke the buildbots. Reverts #34927.