Pass arrays instead of pointers when possible in blas.jl #34783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
an/nopointer
branch
from
2a7b537 to
5d4517f
Compare
|
Looks like the only remaining test failure is unrelated. |
dkarrasch
approved these changes
Feb 19, 2020
andreasnoack
force-pushed
the
an/nopointer
branch
from
5d4517f to
0eed034
Compare
birm
pushed a commit
to birm/julia
that referenced
this pull request
Feb 22, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These weren't needed. We can just rely on the implicit convertion in
ccalland the presence of them gave a false impression that they were needed, see #34320.