Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make REPL ast transforms instance-specific #34626

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Feb 2, 2020

As suggested here, this makes the REPL ast transformation list specific to a REPLBackend instance, though there is a global array of defaults for new instances.

This PR also changes REPL.softscope! to REPL.sofscope. There doesn't seem to be a big advantage to having this function mutating, and the non-mutating version is easier to use safely. (In particular, though passing the mutating version to the new include function in #34595 is safe because the AST expressions are temporary, that would require us to document this property of include which is bothersome.)

@JeffBezanson JeffBezanson added the stdlib:REPL Julia's REPL (Read Eval Print Loop) label Feb 3, 2020
@fredrikekre
Copy link
Member

This PR also changes REPL.softscope! to REPL.sofscope.

Documenter has been patched to use softscope! so in order to get the doc builder to pass on this PR you will have to revert 2c43528

@StefanKarpinski
Copy link
Sponsor Member

Maybe the least disruptive course of action would be:

  1. make softscope! and alias for softscope for the time being
    • I doubt anyone was relying on the side effect, they were probably mapping it
  2. change Documenter to call softscope instead of softscope!
  3. bump the Documenter version that Base uses
  4. delete the softscope! alias

@stevengj
Copy link
Member Author

stevengj commented Feb 10, 2020

What is the remaining doctest error? I'm not sure what is going on…

@KristofferC
Copy link
Sponsor Member

It has been fixed on master but this needs to be rebased to pick it up (CI don't run merge commits now).

@stevengj
Copy link
Member Author

Hooray, green tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants