-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make REPL ast transforms instance-specific #34626
Conversation
Documenter has been patched to use |
Maybe the least disruptive course of action would be:
|
What is the remaining doctest error? I'm not sure what is going on… |
It has been fixed on master but this needs to be rebased to pick it up (CI don't run merge commits now). |
3dccfcb
to
a0013be
Compare
Hooray, green tests! |
As suggested here, this makes the REPL ast transformation list specific to a
REPLBackend
instance, though there is a global array of defaults for new instances.This PR also changes
REPL.softscope!
toREPL.sofscope
. There doesn't seem to be a big advantage to having this function mutating, and the non-mutating version is easier to use safely. (In particular, though passing the mutating version to the newinclude
function in #34595 is safe because the AST expressions are temporary, that would require us to document this property ofinclude
which is bothersome.)