Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docstring for @ at the REPL #33824

Merged
merged 1 commit into from
Apr 21, 2021
Merged

add docstring for @ at the REPL #33824

merged 1 commit into from
Apr 21, 2021

Conversation

jaideep-seth
Copy link
Contributor

@jaideep-seth jaideep-seth commented Nov 12, 2019 •
edited
Loading

This is an attempt for only '@' (One of seven) described in this issue.

Reference: #33666

@mbauman
Copy link
Member

mbauman commented Nov 12, 2019

Welcome @jaideep-seth! This looks like a good take on tackling part of #33666. In general, I encourage you to use more descriptive commit messages — which can then auto-populate your pull request with title and description. Just saying something like: "add docstring for @ at the REPL" would be great — you can still edit the title and body of this PR, which would be very helpful to others.

@mbauman mbauman added the docs This change adds or pertains to documentation label Nov 12, 2019
@jaideep-seth
Copy link
Contributor Author

jaideep-seth commented Nov 12, 2019 •
edited
Loading

Hi @mbauman , this is my first PR in Julia. Please help me get this PR merged.

Thank you so much!

@jaideep-seth jaideep-seth changed the title try1 add docstring for @ at the REPL Nov 12, 2019
@jaideep-seth jaideep-seth mentioned this pull request Nov 14, 2019
Closed
@jaideep-seth
Copy link
Contributor Author

Hey @mbauman i raised an issue ( #33844 ) as the buildbot asked me to in the build log.

Could you please guide me on how i can clear the remaining build tests?
Thank you!

@ViralBShah
Copy link
Member

Hi @jaideep-seth - the buildbots are not related to your PR. Please improve the commit message and make it descriptive as suggested.

@jaideep-seth jaideep-seth mentioned this pull request Dec 8, 2019
Merged
ViralBShah
ViralBShah reviewed Apr 30, 2020
View reviewed changes
@vtjnash @jaideep-seth
doc: add @ to help
7e1d307 
Co-authored-by: jaideep-seth <jaideepnseth@gmail.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 20, 2021
@fredrikekre fredrikekre merged commit 6985788 into JuliaLang:master Apr 21, 2021
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 28, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@jaideep-seth @vtjnash @ElOceanografo
doc: add @ to help (JuliaLang#33824)
0851941 
Co-authored-by: jaideep-seth <jaideepnseth@gmail.com>

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@jaideep-seth @vtjnash @antoine-levitt
doc: add @ to help (JuliaLang#33824)
dbbecf4 
Co-authored-by: jaideep-seth <jaideepnseth@gmail.com>

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@jaideep-seth @vtjnash @johanmon
doc: add @ to help (JuliaLang#33824)
6ad8bf4 
Co-authored-by: jaideep-seth <jaideepnseth@gmail.com>

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralBShah ViralBShah ViralBShah left review comments

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jaideep-seth @mbauman @ViralBShah @vtjnash @simeonschaub @fredrikekre