Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for Julia 1.3-RC4 #33499

Merged
merged 7 commits into from
Oct 14, 2019
Merged

Backports for Julia 1.3-RC4 #33499

merged 7 commits into from
Oct 14, 2019

Conversation

KristofferC
Copy link
Member

No description provided.

JeffBezanson and others added 4 commits October 8, 2019 09:55
@JeffBezanson @KristofferC
improve instanceof_tfunc to take declared parameter bounds into acc…
c76690e 
…ount (#33472)

(cherry picked from commit 7466d11)
@JeffBezanson @KristofferC
add some type info to Base to avoid excess recursion in inference (#3…
039590a 
…3476)

Fixes #33336.
This addresses some commonly-occurring cases where having too little
type info makes inference see a lot of recursion in Base that is
not actually possible.

(cherry picked from commit d5d5718)
@staticfloat @KristofferC
Fix zlib <-> libz confusion within build system
82c6c5d 
(cherry picked from commit 7f1e190)
@staticfloat @KristofferC
Add $(EXE) to the end of 7z when installing it
48d650e 
(cherry picked from commit 5bf7a14)
@KristofferC KristofferC added DO NOT MERGE Do not merge this PR! needs nanosoldier run This PR should have benchmarks run on it needs pkgeval Tests for all registered packages should be run with this change and removed needs nanosoldier run This PR should have benchmarks run on it labels Oct 8, 2019
@KristofferC
Copy link
Member Author

I dont think we need a full PkgEval for this.

@KristofferC KristofferC removed DO NOT MERGE Do not merge this PR! needs pkgeval Tests for all registered packages should be run with this change labels Oct 8, 2019
@staticfloat staticfloat mentioned this pull request Oct 11, 2019
Merged
@fredrikekre fredrikekre force-pushed the backports-release-1.3 branch from 750723e to 5ff1584 Compare October 11, 2019 21:42
@Keno
Copy link
Member

Keno commented Oct 13, 2019

@staticfloat are we waiting for some libz build fixes here? Anything else before we call this good?

@staticfloat
Copy link
Member

After c3e3b7a gets backported, we're ready for an rc4.

@staticfloat @KristofferC
Bump Zlib BB release to v1.2.11+6
40d8a1a 
Fantastic chain of events:

* Zlib BB release `v1.2.11+3` had symlinks in the windows tarball
* These unpacked just fine using Cygwin's `tar` on the windows buildbots
* After building, `7z` sees Cygwin's symlink file contents as a string,
packges it up just fine
* Julia, when installed on a windows machine, unpacks a `libz.dll` that
is a garbage fake symlink file, tries to open `libz.dll` and throws out
a `%1 is not a valid Win32 application.` error.

[0]: https://ci.appveyor.com/project/Ward9250/libz-jl/builds/28054772/job/5jqq9wpk8iaieg6m
@KristofferC KristofferC changed the title WIP: Backports for Julia 1.3-RC4 Backports for Julia 1.3-RC4 Oct 14, 2019
@KristofferC KristofferC merged commit cf648f7 into release-1.3 Oct 14, 2019
@KristofferC KristofferC deleted the backports-release-1.3 branch October 14, 2019 10:27
@KristofferC KristofferC mentioned this pull request Oct 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KristofferC @Keno @staticfloat @JeffBezanson @fredrikekre