Changed check_top_bit InexactError

[jakobnissen]

Currently, converting type of a too large or small integer yields this error message:

julia> UInt(-1)
ERROR: InexactError: check_top_bit(Int64, -1)

However, the documentation of InexactError states:

  InexactError(name::Symbol, T, val)

  Cannot exactly convert val to type T in a method of function name.

This implies that the above error message means that -1 cannot be represented as an Int64. However, that's wrong - it cannot be represented as a UInt64. Furthermore, check_top_bit(Int64, -1) is not a valid function call.

With this change, the error message is:

julia> UInt(-1)
ERROR: InexactError: check_top_bit(UInt64, -1)

Which is correct. Also, check_top_bit now takes a type and a value, so check_top_bit(UInt64, -1) is a valid function call (and is also indeed the call that triggered the error).

There's probably a larger discussion to be had whether it should really be a DomainError instead, but changing the error type is a breaking change.
Also see issue #30247 and issue #29766 .

[JeffBezanson]

Thank you, and welcome! Very good first PR. This looks like quite an oversight. Since this is pretty low-level I'll run benchmarks just in case

@nanosoldier runbenchmarks(ALL, vs = ":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan