RNG: fix Sampler selection for GLOBAL_RNG #33172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
bugfix
nalimilan
reviewed
Sep 5, 2019
stdlib/Random/src/Random.jl
Outdated
| Sampler(rng::AbstractRNG, ::Type{X}, r::Repetition=Val(Inf)) where {X} = Sampler(_typeof(rng), X, r) | ||
|
|
||
| # GLOBAL_RNG currently represents a MersenneTwister | ||
| _typeof(x) = typeof(x) |
There was a problem hiding this comment.
Maybe call this typeof_rng instead? _typeof sounds much more general.
rfourquet
force-pushed
the
rf/rng/fix-Sampler-typeof
branch
from
3d071ec
to
c981bd2
Compare
KristofferC
reviewed
Sep 5, 2019
stdlib/Random/src/Random.jl
Outdated
|
|
||
| # GLOBAL_RNG currently represents a MersenneTwister | ||
| typeof_rng(rng::AbstractRNG) = typeof(rng) | ||
| typeof_rng(::_GLOBAL_RNG) = MersenneTwister |
There was a problem hiding this comment.
_GLOBAL_RNG is not defined here yet.
There was a problem hiding this comment.
Ah right, is this why CI didn't build? I couldn't understand CI failures (am still used to travis interface).
rfourquet
force-pushed
the
rf/rng/fix-Sampler-typeof
branch
from
c981bd2
to
cbf8e9d
Compare
KristofferC
pushed a commit
that referenced
this pull request
Sep 6, 2019
(cherry picked from commit 4c8cd3b)
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33170.