Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #33135, wrong scope resolution with conflicting sparams and let vars #33145

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

JeffBezanson
Copy link
Member

The static parameters of an outer scope should not be passed along to inner scopes; it instead needs to be handled by the lookup process iterating back to enclosing scopes.

The static parameters of an outer scope should not be passed along
to inner scopes; it instead needs to be handled by the lookup process
iterating back to enclosing scopes.
@JeffBezanson JeffBezanson added compiler:lowering Syntax lowering (compiler front end, 2nd stage) backport 1.2 bugfix This change fixes an existing bug labels Sep 3, 2019
@JeffBezanson
Copy link
Member Author

We might not backport anything more to 1.2, but just noting that the bug occurs there as well. 1.1 is ok.

@KristofferC KristofferC mentioned this pull request Sep 3, 2019
36 tasks
@JeffBezanson JeffBezanson merged commit 0fc3f03 into master Sep 4, 2019
@JeffBezanson JeffBezanson deleted the jb/fix33135 branch September 4, 2019 16:37
KristofferC pushed a commit that referenced this pull request Sep 5, 2019
…ars (#33145)

The static parameters of an outer scope should not be passed along
to inner scopes; it instead needs to be handled by the lookup process
iterating back to enclosing scopes.

(cherry picked from commit 0fc3f03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants