Workaround for performance penalty of splatting a number #33108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround for the performance penalty of splatting a number (#29114) which is problematic in
mul!
performance.I don't know the time-frame of the solution of #29114 but it may make sense to have this workaround until we have a builtin solution for #29114?
close #33105; cc @dkarrasch @KristofferC
Quick benchmarks
Before (9a8b2fd):
After (aeaa464):
The difference to the broadcasting may be the
@simd
macro.