-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an LRU cache to precompile files #32651
Conversation
57343e7
to
51290ae
Compare
cc @tkf who have been thinking about these stuff as well |
Thinking about this a little more the implementation in this PR is non ideal because iteratively working on a project for a while will quickly clobber the whole cache of precompilation files. We need to get the path of the current active project in there. Will amend this PR. |
I think the tricky part is supporting switching projects. If you interleave I think an easier solution would be to use |
5ae65b8
to
f43434c
Compare
Re early my comment #32651 (comment) |
instead of always clobbering the one precompile file per package for multiple environments, introduce a LRU cache (10 files that we cycle through).
f43434c
to
6aae086
Compare
Let's merge this by the end of the day unless somebody speaks up. This is a great improvement over the current situation so it would be good to have included in 1.3 even if we want to adjust the details later. |
instead of always clobbering the one precompile file per package for multiple environments, introduce a LRU cache (10 files that we cycle through).
less clobbering of precompilation files when changing environments is the #1 reason i'd upgrade to 1.3. unless i missed it, this PR is not mentioned in HISTORY.md. worth adding i think. |
instead of always clobbering the one precompile file per package for multiple environments, introduce a LRU cache (maximum of, currently, 10 files).
Fixes #27418