fix #32465, inference of splatting unionall NamedTuple types #32494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
vtjnash
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
I wrote up a comment about what I think this logic is intended to do.
A more literal translation of the comment into code seems to be:
tti0 = rewrap_unionall(tti.parameters[2], tti0)
# optional: has_free_typevars(tti) && return Any[Vararg{Any}]
tti = unwrap_unionall(tti0)These are usually the same thing, I think the only case they differ is if the Tuple parameter was itself a UnionAll (in which case the PR would be still correct, but less optimal).
Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32465