Two fixes to win32 cross compilation #32072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The default mingw32 gfortran on ubuntu prints the version as `GNU Fortran (GCC) 7.3-win32 20180312`, rather than `7.3.0` most other gfortrans do, so be robust to that in normalize_triplet - When shelling out to python use the host path rather than the windows-equivalent path, since python is a host tool.
staticfloat
approved these changes
May 18, 2019
|
backport to 1.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU Fortran (GCC) 7.3-win32 20180312,rather than
7.3.0most other gfortrans do, so be robust to that in normalize_tripletis a host tool.