subtyping: apply performance optimization in more places #31807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
vtjnash
force-pushed
the
jn/subtype-perf2
branch
2 times, most recently
from
9bfe621
to
2b64b2b
Compare
…bviously_disjoint
also need to address some bugs in the optimizer since supertype(T=typeof(Union{})) is awkwardly equal to T,
even though they are also expected to be distinguishable,
and similarly, we might get tripped up to discover that `Tuple{T}` where `isconcretetype(T)` has does subtypes
and so these optimizations were being too aggressive
also consider the whole Vararg tail, looking for obvious conflicts
this skips validation for malformed types with free type vars
| t = jl_unwrap_unionall(t); | ||
| if (jl_is_datatype(t)) { | ||
| if (jl_is_type_type(t)) | ||
| return 0; // Type{T} may have the concrete supertype `typeof(T)`, so don't try to handle them here |
There was a problem hiding this comment.
I thought it was the other way around --- that typeof(T) could have Type{T} as its supertype?
There was a problem hiding this comment.
julia> T = Int; Type{T} <: typeof(T)
true
There was a problem hiding this comment.
Ah, I thought you meant the .super field.
| @@ -227,8 +227,8 @@ let ft = Base.datatype_fieldtypes | |||
| @test ft(elT2.body)[1].parameters[1] === elT2 | |||
| @test Base.isconcretetype(ft(elT2.body)[1]) | |||
| end | |||
| struct S22624{A,B,C} <: Ref{S22624{Int64,A}}; end | |||
| @test @isdefined S22624 | |||
| #struct S22624{A,B,C} <: Ref{S22624{Int64,A}}; end | |||
There was a problem hiding this comment.
Looks like we should try to merge #25796 first?
There was a problem hiding this comment.
I think they end up being somewhat unrelated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marked draft, because it'll conflict with #31698, and there will need to be more improvements/corrections to jl_obvious_subtype after that is merged