RFC: Embed an error when a generator fails. #31756
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25707, and also results in more GPU compatible code since it doesn't dynamically dispatch to the generator in order to throw an error.
Some thoughts/TODO's:
Expr(:error, e)
doesn't work becausejl_expand(Expr(:lambda, ...))
doesn't return aCodeInfo
then?Also, the new behavior is shown by
code_typed
but notcode_warntype
, I'm not sure why that's the case (probably #31764):