Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a macro which chains transformations on collections. #31646

Closed
wants to merge 1 commit into from
Closed

Added a macro which chains transformations on collections. #31646

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2019

Chaining multiple operations on collections looked like a common task. That's why I added it to base library.

@jpsamaroo
Copy link
Member

I'm not sure if this functionality is desired in Base or Stdlib (maybe I'm missing some pre-existing discussion about this), but if it is, you should:

  • Add tests
  • Update NEWS.md
  • Provide a few motivating examples of where one could use @chain to great benefit over alternatives

@JeffBezanson
Copy link
Member

Welcome, @sagartewari01, thanks for making a PR.

See e.g. #5571 (comment) for several alternate designs of things like this that have been proposed. I don't think we're ready/willing to commit to adding something like this to Base.

@jpsamaroo is right that we require tests, but it can be OK to make a proposal without writing detailed tests until design discussion is complete.

@ghost
Copy link
Author

ghost commented Apr 8, 2019

@JeffBezanson Thanks a lot, the thread was informative.

@ghost ghost closed this Apr 8, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants