Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis, which has problems with BB #31605

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Fix Travis, which has problems with BB #31605

merged 2 commits into from
Apr 5, 2019

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Apr 3, 2019

Disable libunwind and libuv because they were built with ld version 2.26 and linking against static libraries with an older ld is apparently not as compatible as we would like.

@staticfloat
Copy link
Member Author

staticfloat commented Apr 4, 2019

As best I can tell, the i686 Travis failure (complaining about undefined reference to '__stack_chk_fail') might be fixed by manually including -lssp? I'm not sure, just reading off of Stack Overflow. I'm confused because we have -fstack-protector-all already being sent to the compiler, so I would think that -lssp would be unnecessary.

@vchuravy
Copy link
Member

vchuravy commented Apr 4, 2019

We set

$$([ $(OS) = WINNT ] && echo '' -lssp))
and

julia/Make.inc

Line 1126 in e49a7c7

OSLIBS += -lssp
here.

@staticfloat
Copy link
Member Author

Thanks Valentin, that's really helpful.

@staticfloat
Copy link
Member Author

This is a little conservative, (disabling BB-built LLVM wholesale) but I think it's worth it to fix it now and then iterate on it later if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants