Accept a function to strip like rstrip and lstrip #31211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2019
|
I'm not sure why but @simonbyrne didn't add that method in #27309 (comment). |
|
I think it was an oversight as that PR got modified. |
simonbyrne
approved these changes
Mar 2, 2019
| @@ -53,6 +53,7 @@ end | |||
| @test strip(" \u2009 hi \u2009 ") == "hi" | |||
| @test strip("foobarfoo", ['f','o']) == "bar" | |||
| @test strip("foobarfoo", ('f','o')) == "bar" | |||
| @test strip(ispunct, "¡Hola!") == "Hola" | |||
StefanKarpinski
approved these changes
Mar 3, 2019
`strip` is documented to accept a function argument but it does not. `rstrip` and `lstrip` do, so it seems this was simply an oversight. See #31195.
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripis documented to accept a function argument but it does not.rstripandlstripdo, so it seems this was simply an oversight.Fixes #31195.
NOTE: #31213 should be merged first!