Fix NamedTuple fallback constructor #26040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Feb 13, 2018
|
@JeffBezanson we really need testing on this code |
|
There's more things wrong with this constructor. Working on it. |
|
Completely agree. |
Fix a typo that breaks things if inference decides it needs NamedTuples during inference. Fix signature of NamedTuple identity conversion to make sure it's more specific
JeffBezanson
force-pushed
the
kf/namedtuplefallback
branch
from
dab4528 to
4762839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo that breaks things if inference decides it needs NamedTuples during inference.