improve heuristics for executing top-level code #24600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 14, 2017
| if (head == toplevel_sym || head == thunk_sym) { | ||
| return; | ||
| } | ||
| else if (head == global_sym || head == const_sym || head == copyast_sym) { |
There was a problem hiding this comment.
global_sym isn't a definition anymore, it's just a scope annotation
copyast also doesn't seem like it defines anything, it's just a local allocation (albeit one that commonly appears in contexts related to defining code)
There was a problem hiding this comment.
I don't think that's true; global as a scope annotation gets removed by the front end, but when it serves to create an (initially undefined) global variable the global expression remains.
one that commonly appears in contexts related to defining code
Yes, that's what I was thinking.
JeffBezanson
force-pushed
the
jb/toplevel_heuristics
branch
from
645794d to
30fef62
Compare
JeffBezanson
force-pushed
the
jb/toplevel_heuristics
branch
from
30fef62 to
2215e01
Compare
also avoid inferring blocks with method definitions and other forms used only at load time. helps #24316.
JeffBezanson
force-pushed
the
jb/toplevel_heuristics
branch
from
2215e01 to
e8073cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code that decides how to execute top-level expressions, separating the identification of key features of the code from using it to make decisions.
It also skips inference for blocks containing load-time-ish forms like method and type definitions, since it's probably not profitable and helps avoid unsoundness issues like #24316. Of course it doesn't fully fix ~~ #24569, but will help in common cases. The reduction in compiler time also makes
using DataFrames(with--compiled-modules=no) about 10% faster for me.