Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC fixes in libgit2 round 2 electric boogaloo #24523

Merged
merged 1 commit into from
Nov 8, 2017
Merged

GC fixes in libgit2 round 2 electric boogaloo #24523

merged 1 commit into from
Nov 8, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Nov 8, 2017

#24464 haven't gotten everything in here (not sure how to handle the BlameHunk and DiffDelta stuff) but I think i did capture most of the unsafe_* business...

@kshyatt kshyatt added GC Garbage collector libgit2 The libgit2 library or the LibGit2 stdlib module labels Nov 8, 2017
@kshyatt kshyatt requested a review from Keno November 8, 2017 01:39
Keno
Keno approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but as you said there's still the embedded pointers in the BlameHunk and IndexEntry structs.

@kshyatt
Copy link
Contributor Author

kshyatt commented Nov 8, 2017

Good to go? what's up with circleci?

@yuyichao
Copy link
Contributor

yuyichao commented Nov 8, 2017

what's up with circleci?

OOM.

@kshyatt kshyatt merged commit 8d67226 into master Nov 8, 2017
@kshyatt kshyatt deleted the ksh/gcstrikesback branch November 8, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
GC Garbage collector libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyatt @yuyichao @Keno