Make next behave like nextind for String #24423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to avoid throwing at all, i.e. also return |
|
I am putting this on hold given @StefanKarpinski comment in #24420 is resolved (as this PR would be redundant then). |
Liso77
reviewed
Oct 31, 2017
| @inbounds for j = 1:(trailing + 1) | ||
| for j in (i+1):l | ||
| @inbounds if !is_valid_continuation(codeunit(s, j)) | ||
| return '\ufffd' j |
There was a problem hiding this comment.
comma is missing here? return '\ufffd', j
There was a problem hiding this comment.
thank you for the catch! I will fix it is decided that this should be merged (for now I feel that the proposal of @StefanKarpinski in #24420 will make it redundant).
|
closing as outdated by #24439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example implementation of #24420 so that we can have a look what overhead it creates. Basically it adds one
is_valid_continuationcheck at each iteration.