Fix JavaScript randmatstat matrix calculations #24385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @johnfgibson to take a look. |
|
Unfortunately I've got a really tough week coming up and will probably not be able to look at this carefully until next weekend. But I will then. Thanks for the fix, @Enet4. |
|
I got a chance to dive into this, and looks good. |
ararslan
pushed a commit
that referenced
this pull request
Nov 10, 2017
(cherry picked from commit 268f878)
ararslan
pushed a commit
that referenced
this pull request
Nov 14, 2017
(cherry picked from commit 268f878)
ararslan
pushed a commit
that referenced
this pull request
Nov 21, 2017
(cherry picked from commit 268f878)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the calculations in the JavaScript micro benchmark analogous to the Julia code
trace((P.'*P)^4)had some issues:P.'*Pwas incorrectly sized asn x n, instead of the actual4n x 4x. JavaScriptFloat64Arrays do not throw an error when reading or writing outside of its boundaries, which probably contributed to the confusion.PMatMulandQMatMulwere being calculated twice. I took the trick from the C benchmark and calculated a second power of two after the first, while reusing matrices where possible.This seems to make the function more than 3 times slower, but it favours fairness towards the other benchmarks. In the future, one might consider making a version of the same program
that compiles to WebAssemblyin asm.js.