Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate full from test/linalg/qr.jl #24009

Merged
merged 1 commit into from
Oct 11, 2017
Merged

eliminate full from test/linalg/qr.jl #24009

merged 1 commit into from
Oct 11, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Oct 5, 2017

Another small step towards deprecation of full. Ref. JuliaLang/LinearAlgebra.jl#229, JuliaLang/LinearAlgebra.jl#231, #18850, and linked threads. Best!

@Sacha0 Sacha0 added the linear algebra Linear algebra label Oct 5, 2017
@Sacha0 Sacha0 added this to the 1.0 milestone Oct 5, 2017
@JeffBezanson
Copy link
Member

Does this replace #24007?

@Sacha0
Copy link
Member Author

Sacha0 commented Oct 6, 2017

Does this replace #24007?

#24007 addresses test/linalg/lq.jl, whereas this pull request addresses tests/linalg/qr.jl :).

@andreasnoack andreasnoack merged commit cd8bda2 into JuliaLang:master Oct 11, 2017
@Sacha0 Sacha0 deleted the nixfulltqr branch October 11, 2017 21:23
@Sacha0
Copy link
Member Author

Sacha0 commented Oct 11, 2017

Thanks all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

@andreasnoack andreasnoack Awaiting requested review from andreasnoack

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@Sacha0 @JeffBezanson @fredrikekre @andreasnoack