Clean up string indexing #23799
Clean up string indexing #23799
Conversation
| @@ -640,14 +640,14 @@ function rtruncto(str::String, w::Int) | |||
| if length(str) <= w | |||
| return str | |||
| else | |||
| return string("...", str[end-w+4:end]) | |||
| return string("...", str[chr2ind(str, length(str)-w+4):end]) | |||
There was a problem hiding this comment.
It likely won't matter in practice but it might be better to use endof(str) to ensure that it's a valid index.
There was a problem hiding this comment.
Unfortunately no as endof(str) returns byte index.
What we want to do here is go back w-4 characters from endof(str). We could run w+4 times prevind from endof(str), but this is cumbersome so that is why I have used chr2ind and performed the calculations on character indices not byte indices and only converted them to byte index at the end with chr2ind (which is inefficient, but I guess in this application it should not be a problem).
I hope to make such calculations simpler and more efficient with #23765 in the future.
|
@ararslan Is it good to merge? |
|
Yep, CI failures look unrelated. |
Results of a review of Julia code base for arithmetic operations on string indices.