Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-codegen: make jl_dump_compiles test more reliable #23486

Merged
merged 1 commit into from
Aug 29, 2017
Merged

test-codegen: make jl_dump_compiles test more reliable #23486

merged 1 commit into from
Aug 29, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 28, 2017

This was a flaky test, since it's not entirely clear what it was testing (as seen from #23365). I think this should make it more reliable.

@vtjnash
test-codegen: make jl_dump_compiles test more reliable
02d9a7e 
This was a flaky test, since it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1
@vtjnash vtjnash added test This change adds or pertains to unit tests backport pending 0.6 labels Aug 28, 2017
@yuyichao yuyichao mentioned this pull request Aug 28, 2017
Merged
@vtjnash vtjnash merged commit 46bff1b into master Aug 29, 2017
@vtjnash vtjnash deleted the jn/jl_dump_compiles-test branch August 29, 2017 18:26
@fredrikekre fredrikekre mentioned this pull request Aug 29, 2017
Closed
@fredrikekre
Copy link
Member

This seem to still be a problem? From #23514

Worker 17 failed running test codegen:
Some tests did not pass: 86 passed, 1 failed, 0 errored, 0 broken.codegen: Test Failed
  Expression: tempty == true
   Evaluated: false == true
Stacktrace:
 [1] record(::Base.Test.DefaultTestSet, ::Base.Test.Fail) at .\test.jl:651
 [2] (::getfield(Main, Symbol("##40#44")))() at C:\projects\julia\julia-11856199d8\share\julia\test\runtests.jl:160
 [3] cd(::getfield(Main, Symbol("##40#44")), ::String) at .\file.jl:59
 [4] include_relative(::Module, ::String) at .\loading.jl:464
 [5] include(::Module, ::String) at .\sysimg.jl:14
 [6] process_options(::Base.JLOptions) at .\client.jl:315
 [7] _start() at .\client.jl:383

@fredrikekre fredrikekre mentioned this pull request Sep 4, 2017
Merged
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@vtjnash @ararslan
test-codegen: make jl_dump_compiles test more reliable (#23486)
34b9527 
This was a flaky test, and it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1

Ref #23486
(cherry picked from commit 46bff1b)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@vtjnash @ararslan
test-codegen: make jl_dump_compiles test more reliable (#23486)
e35ba8e 
This was a flaky test, and it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1

(cherry picked from commit 46bff1b)
vtjnash added a commit that referenced this pull request Sep 14, 2017
@vtjnash
test-codegen: make jl_dump_compiles test more reliable (#23486)
5b444ca 
This was a flaky test, and it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1

(cherry picked from commit 46bff1b)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@vtjnash @ararslan
test-codegen: make jl_dump_compiles test more reliable (#23486)
eb0e9e5 
This was a flaky test, and it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1

(cherry picked from commit 46bff1b)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
@vtjnash @ararslan
test-codegen: make jl_dump_compiles test more reliable (#23486)
3caf37c 
This was a flaky test, and it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1

(cherry picked from commit 46bff1b)
ararslan pushed a commit that referenced this pull request Sep 18, 2017
@vtjnash @ararslan
test-codegen: make jl_dump_compiles test more reliable (#23486)
2fe7cb9 
This was a flaky test, and it's not entirely clear what it was testing.

Common failure was:
        FAILURE
    Error in testset codegen:
    Test Failed
      Expression: tempty == true
       Evaluated: false == true
    ERROR: LoadError: Test run finished with errors
    while loading C:\projects\julia\julia-a661736be5\share\julia\test\runtests.jl, in expression starting on line 29
    Command exited with code 1

(cherry picked from commit 46bff1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtjnash @fredrikekre @ararslan