Doc rebase stuff #23432
Merged
Doc rebase stuff #23432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
ararslan
reviewed
Aug 24, 2017
base/libgit2/types.jl
Outdated
| should be done "quietly". Used for interoperability. The default is `1`. | ||
| * `inmemory`: start an in-memory rebase. Callers working on the rebase can go through its | ||
| steps and commit any changes, but cannot rewind HEAD or update the repository. The | ||
| [`workdir`](@ref) will not be modified. Only present on libgit2 versions newer than 0.24.0. |
There was a problem hiding this comment.
"Newer than" implies to me strictly greater than 0.24.0, which suggests that it was introduced in 0.24.1. Is that accurate?
There was a problem hiding this comment.
@static if LibGit2.VERSION >= v"0.24.0"
should we change to "as least as new as"?
There was a problem hiding this comment.
That or "version 0.24.0 or newer."
picked "newer than or equal to" for consistency with existing docstrings
ararslan
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.