Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libuv commit #23326

Merged
merged 1 commit into from
Aug 26, 2017
Merged

bump libuv commit #23326

merged 1 commit into from
Aug 26, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 18, 2017 •
edited by tkelman
Loading

fixes UV_HANDLE_EMULATE_IOCP handling for Windows pipes, closing #11727

@ararslan ararslan added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Aug 18, 2017
@tkelman
Copy link
Contributor

tkelman commented Aug 19, 2017

closing #11727

Needs test.

tkelman
tkelman suggested changes Aug 19, 2017
View reviewed changes
Copy link
Contributor

@tkelman tkelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update checksums

@vtjnash
update libuv
be45cf5 
fixes UV_HANDLE_EMULATE_IOCP handling for Windows pipes

close #11727
@tkelman tkelman added the needs tests Unit tests are required for this change label Aug 25, 2017
@vtjnash vtjnash merged commit e89d150 into master Aug 26, 2017
@vtjnash vtjnash deleted the jn/11727 branch August 26, 2017 22:16
@vtjnash vtjnash added backport pending 0.6 and removed needs tests Unit tests are required for this change labels Aug 26, 2017
@vtjnash
Copy link
Member Author

vtjnash commented Aug 26, 2017

Will test when it is submitted upstream.

@tkelman
Copy link
Contributor

tkelman commented Aug 27, 2017

please add a julia level integration test to verify the consequence we encountered

ararslan pushed a commit that referenced this pull request Sep 11, 2017
@vtjnash @ararslan
update libuv (#23326)
424f007 
fixes UV_HANDLE_EMULATE_IOCP handling for Windows pipes

close #11727

Ref #23326
(cherry picked from commit e89d150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman requested changes

Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtjnash @tkelman @ararslan