Tweak debug info lookup to ignore dladdr result where it cannot be trusted #22549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jun 26, 2017
src/debuginfo.cpp
Outdated
| *context = NULL; | ||
| *slide = 0; | ||
| *section_slide = 0; | ||
| // On Windows and FreeBSD, `dladdr` (or it's equivalent) returns the closest exported symbol |
tkelman
reviewed
Jun 26, 2017
src/debuginfo.cpp
Outdated
| // when better result is available through other methods. | ||
| // macOS's `dladdr` returns local symbols and Linux's `dladdr` | ||
| // checks the symbol size so they do not have this problem. | ||
| // On systems with a untrusted dladdr, the result cannot be used for sysimg |
|
This PR builds successfully on FreeBSD CI: https://julia.iblis.cnmc.tw/#/builders/2/builds/106 |
|
Update README as well diff --git a/README.md b/README.md
index 34bf2ac71f..4dcf304f58 100644
--- a/README.md
+++ b/README.md
@@ -256,7 +256,6 @@ Some known issues on FreeBSD are:
* The x86 architecture does not support threading due to lack of compiler runtime library support, so you may need to
set `JULIA_THREADS=0` in your `Make.user` if you're on a 32-bit system.
-* Some stack trace information is not available due to differences with libunwind.
### Windows |
Similar to windows' `SymFromAddr` it only find the closest exported symbol without checking symbol size and can therefore return incorrect result for local functions. Also reorganize the code so that the function name and base lookup is always down even when the LLVM object lookup failed.
Similar to Linux. The LLVM fallback is currently not working on FreeBSD for some reason. Fix: #20798
yuyichao
force-pushed
the
yyc/local_function_lookup
branch
from
e0eb9c3 to
3891cca
Compare
|
That link return 504 for me but I'll take your word that it works and merge when the CI finishes again.... |
|
@yuyichao seems my server crashed 8 hr ago... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should disable broken linfo lookup on FreeBSD due to difference in
dladdrbehavior (none of the three platforms we support building that hasdladdrhave the same behavior.....).Enable
libunwindlookup code path since apparently that works on FreeBSD too.Fix: #20798