-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference all the numbers #22107
Merged
KristofferC
merged 24 commits into
JuliaLang:master
from
fredrikekre:fe/reference-all-the-things
May 29, 2017
Merged
Reference all the numbers #22107
KristofferC
merged 24 commits into
JuliaLang:master
from
fredrikekre:fe/reference-all-the-things
May 29, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
May 28, 2017
base/operators.jl
Outdated
@@ -545,7 +545,8 @@ julia> bits(Int8(-14)) | |||
julia> bits(Int8(60)) | |||
"00111100" | |||
``` | |||
`BigInt`s are treated as if having infinite size, so no filling is required and this | |||
|
|||
[`BigInt`](@ref)'s are treated as if having infinite size, so no filling is required and this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no apostrophe here
fredrikekre
force-pushed
the
fe/reference-all-the-things
branch
from
May 28, 2017 15:14
543c343
to
9ce4465
Compare
ararslan
approved these changes
May 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should be squashed on merge.
tkelman
pushed a commit
that referenced
this pull request
Jun 3, 2017
* references for Rational * references for Complex * references for Number * references to Real * references for AbstractFloat * references for Integer * references for Signed * references for Unsigned * references to Bool * references for Float16 * references for Float32 * references for Float64 * references for Int8 * references for UInt8 * references for Int16 * references for UInt16 * references for Int32 * references for UInt32 * references for Int64 * references for UInt64 * references for Int128 * references for UInt128 * references for BigInt * references for BigFloat (cherry picked from commit 96e4301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #22067