Optimize sysimg TLS access on Linux #21738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
added
compiler:codegen
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
tkelman
reviewed
May 7, 2017
| auto T_int8 = Type::getInt8Ty(ctx); | ||
| auto T_pint8 = PointerType::get(T_int8, 0); | ||
| # if defined(_CPU_X86_64_) || defined(_CPU_X86_) | ||
| // Workaround LLVM bug by hiding the offset computation |
There was a problem hiding this comment.
which bug, is this tracked somewhere?
There was a problem hiding this comment.
could you put that in the comment for future reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function call showed up in @Keno's profile at some point. This basically makes the sys.so version almost as fast as the jit version (one more load and one more not taken branch) when loaded by the julia executable.
@nanosoldier
runbenchmarks(ALL, vs=":master")