improve two deprecations #20529
Merged
improve two deprecations #20529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
requested changes
Feb 8, 2017
| ex = ccall(:jl_parse_input_line, Any, (Ptr{UInt8}, Csize_t, Ptr{UInt8}, Csize_t), | ||
| s, sizeof(s), filename, sizeof(filename)) | ||
| if ex === :_ | ||
| # remove with 0.6 deprecation |
There was a problem hiding this comment.
Best practice at the moment is to drop a comment in base/deprecated.jl about this TODO.
JeffBezanson
force-pushed
the
jb/improvedeps
branch
from
6a518bd to
02f020e
Compare
StefanKarpinski
approved these changes
Feb 8, 2017
|
This is safe to merge since the test failure on macOS was unrelated and random (my fault for adding lots of range tests that apparently sometimes actually fail.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_by itself at the prompt