[release-0.5] Fix computation of range length in certain cases (fix 0.5/#20373) #20396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
changed the title
|
@tkelman: is there a known problem with CI for 0.5, is this why you can't get 0.5.1 out? |
|
Blocked on #20483. |
|
I don't want to merge behavior changes onto release-0.5 without regression-testing them against pkgeval, so I'm going to change the target branch of this and pull it into a larger backport branch first |
|
I need to update this to include further fixes. Now that CI should work, I can push that. |
StefanKarpinski
force-pushed
the
sk/frfix0.5
branch
from
990ddf6 to
b5e1b25
Compare
This is the 0.5 edition: with this change a, b, n are always hit
exactly by a:s:a+n*s construction tests. There are two parts to
the fix: 1) check that the lifted rational endpoint is exact even
*after* we've reduced terms of the fractions; 2) apply the same
fix that I've proposed for the length in the non-lifted case.
Combined backport of these commits:
- e849169
- b7ad743
range tests: allow any range length that hits stop (#20532)
(cherry picked from commit b7ad743)
StefanKarpinski
force-pushed
the
sk/frfix0.5
branch
from
b5e1b25 to
03f5df7
Compare
|
This is ready to go for 0.5, @tkelman. Feel free to merge, cherry-pick, whatever suits you. |
|
Bump. |
This was referenced Mar 1, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 0.5 edition: with this change a, b, n are always hit exactly by
a:s:a+n*sconstruction tests. There are two parts to the fix: