don't warn about redefining methods in Main #19888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #18725 by silencing the "Method definition overwritten" warnings when both the new and old methods are in
Main
.The warnings are useful for modules, where overwritten methods are usually an error, but are incredibly annoying and confusing during interactive work in the REPL (or IJulia etc.). (Now that #265 is fixed, redefining functions is much less dangerous, so most of the concerns raised in #18725 should now be moot.)
With this PR: