run each Expr(toplevel) argument in the newest world #19861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there something within base that could test this? |
|
See how I tested #19784 for example. |
vtjnash
force-pushed
the
jn/toplevel_eval_world
branch
from
1bd1c03 to
4d82e2a
Compare
tkelman
reviewed
Jan 17, 2017
| @@ -414,6 +414,26 @@ test_parseerror("0x1.0p", "invalid numeric constant \"0x1.0\"") | |||
| try = "No" | |||
| """)) == Expr(:error, "unexpected \"=\"") | |||
|
|
|||
| # issue #19861 make sure macro-expansion happens in the newest world for top-level expression | |||
| @test eval(Base.parse_input_line(""" | |||
There was a problem hiding this comment.
would include_string be any better?
There was a problem hiding this comment.
nah, the include_string code-path was fine. this is an an entirely different bit of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the coverage submission: https://build.julialang.org/builders/coverage_ubuntu14.04-x64/builds/859/steps/Gather%20test%20results%20and%20Submit/logs/stdio