Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove closure around @async et al #19558

Closed
wants to merge 1 commit into from

Conversation

bjarthur
Copy link
Contributor

closes #18227 and #19468

@andreasnoack
Copy link
Member

cc: @amitmurthy

@bjarthur
Copy link
Contributor Author

ooh. this is a bigger job than i imagined. every use in Base of async, fetch, fetchfrom, spawn, and spawnat must be audited for the removal of the closure.

@amitmurthy
Copy link
Contributor

We just need to remove the call to localize_vars. And remove localize_vars too as no other code uses it. The expressions still needs to be wrapped in a closure which is what is serialized and executed remotely.

@kshyatt kshyatt added the domain:parallelism Parallel or distributed computation label Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socket closes prematurely
5 participants