Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail to installed(pkg) doc #19435

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Add detail to installed(pkg) doc #19435

merged 1 commit into from
Dec 6, 2016

Conversation

alexmorley
Copy link
Contributor

Could be some confusion to this ... see e.g. SO question

@kshyatt kshyatt added docs This change adds or pertains to documentation packages Package management and loading labels Nov 27, 2016
kshyatt
kshyatt requested changes Nov 27, 2016
View reviewed changes
Copy link
Contributor

@kshyatt kshyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to change the docstring in the Julia source file at base/pkg/pkg.jl, then run make docs and the stdlib file will be updated too. The way you have this now, the next time someone runs make docs your improvement will be overwritten.

@alexmorley alexmorley mentioned this pull request Dec 4, 2016
Closed
@alexmorley
Copy link
Contributor Author

OK I have done that now. Thanks @kshyatt

@alexmorley alexmorley closed this Dec 4, 2016
@alexmorley alexmorley reopened this Dec 4, 2016
kshyatt
kshyatt approved these changes Dec 4, 2016
View reviewed changes
Copy link
Contributor

@kshyatt kshyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@martinholters martinholters merged commit dedd3cd into JuliaLang:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyatt kshyatt kshyatt approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation packages Package management and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexmorley @kshyatt @martinholters