Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize isdefined on normal objects in codegen #19334

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Optimize isdefined on normal objects in codegen #19334

merged 1 commit into from
Nov 17, 2016

Conversation

yuyichao
Copy link
Contributor

We can do constant folding on isdefined in type inference too but I doubt it's very useful.

Not sure if we have benchmarks that are sensitive to this.
@nanosoldier runbenchmarks(ALL, vs=":master")

@yuyichao yuyichao added compiler:codegen Generation of LLVM IR and native code performance Must go faster labels Nov 15, 2016
@StefanKarpinski
Copy link
Sponsor Member

What's the beneficial effect of this? Faster codegen?

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@yuyichao
Copy link
Contributor Author

Any use of "isdefined on normal objects" in general?

@yuyichao yuyichao merged commit ec26f3c into master Nov 17, 2016
@yuyichao yuyichao deleted the yyc/codegen/isdefined branch November 17, 2016 13:18
@JeffBezanson JeffBezanson mentioned this pull request Jan 9, 2017
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuyichao @StefanKarpinski @nanosoldier @JeffBezanson