fix #17758, deprecate is
#18978
fix #17758, deprecate is
#18978
Conversation
| @@ -324,7 +323,7 @@ end | |||
|
|
|||
| function pop!(t::ObjectIdDict, key::ANY) | |||
| val = pop!(t, key, secret_table_token) | |||
| !is(val,secret_table_token) ? val : throw(KeyError(key)) | |||
| val !== secret_table_token ? val : throw(KeyError(key)) | |||
There was a problem hiding this comment.
maybe check that this doesn't cause a performance regression?
There was a problem hiding this comment.
From what I can tell !== always gets inlined.
| tchanged(n::ANY, o::ANY) = is(o,NF) || (!is(n,NF) && !(n ⊑ o)) | ||
| schanged(n::ANY, o::ANY) = is(o,NF) || (!is(n,NF) && !issubstate(n, o)) | ||
| tchanged(n::ANY, o::ANY) = o===NF || (n!==NF && !(n ⊑ o)) | ||
| schanged(n::ANY, o::ANY) = o===NF || (n!==NF && !issubstate(n, o)) |
There was a problem hiding this comment.
also performance here (and so on)
There was a problem hiding this comment.
Inference performance regressions probably weren't caught by nanosoldier. This probably regressed somehow, but it's probably not a big deal.
Edit: Apparently !== still gets inlined. Huh.
| @test is(typeof(Set([1,2,3])), Set{Int}) | ||
| @test is(typeof(Set{Int}([3])), Set{Int}) | ||
| @test ===(typeof(Set([1,2,3])), Set{Int}) | ||
| @test ===(typeof(Set{Int}([3])), Set{Int}) |
There was a problem hiding this comment.
these should probably be isa ?
There was a problem hiding this comment.
Yes; this way was just easier search-replace.
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @jrevels |
No description provided.