Couple of small docs fixes #18784
Couple of small docs fixes #18784
Conversation
|
Would it make sense to have Travis/AppVeyor run |
| @@ -3059,14 +3059,6 @@ Return `true` if `A` is a subset of or equal to `S`. | |||
| issubset | |||
|
|
|||
| """ | |||
| stringmime(mime, x) | |||
There was a problem hiding this comment.
Was this copied out of helpdb and someone forgot to remove it?
| @@ -1545,7 +1565,7 @@ Internals | |||
| julia> M.f() | |||
| (1,2) | |||
|
|
|||
| With @macroexpand the expression expands where @macroexpand appears in the code (module M). With macroexpand the expressions expands in the current module where the code was finally called. Note that when calling macroexpand or @macroexpand directly from the REPL, both of these contexts coincide, hence there is no difference. | |||
| With ``@macroexpand`` the expression expands where ``@macroexpand`` appears in the code (module ``M``\ ). With ``macroexpand`` the expressions expands in the current module where the code was finally called (REPL). Note that when calling ``macroexpand`` or ``@macroexpand`` directly from the REPL, both of these contexts coincide, hence there is no difference. | |||
There was a problem hiding this comment.
ref #18660 (comment) I think we should delete this (REPL) parenthetical both here and at the source, since it's confusing and not very general.
There was a problem hiding this comment.
See my comment #18660 (comment) there.
There was a problem hiding this comment.
Updated accordingly.
|
Yes we should do some sort of doc building on CI. Last time I tried I couldn't come up with something that didn't result in too frequently recompiling the system image. And the doc building mechanism will probably be changing soon. |
|
I believe I need this PR in order to fix the issues Tony mentions here: #18484 (comment) |
| With `@macroexpand` the expression expands where `@macroexpand` appears in the code (module `M`). | ||
| With `macroexpand` the expressions expands in the current module where the code was finally called (REPL). | ||
| With `@macroexpand` the expression expands where `@macroexpand` appears in the code (module | ||
| `M` in the example). With `macroexpand` the expressions expands in the current module where |
There was a problem hiding this comment.
"expression expands", right?
There was a problem hiding this comment.
I guess so. Anything else?
...which where probably forgotten to commit in other PRs.
martinholters
force-pushed
the
mh/docfixes
branch
from
bd8a913 to
1aca433
Compare
...which where probably forgotten to commit in other PRs.