Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support set/get_zero_subnormals on AArch64 #18578

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Support set/get_zero_subnormals on AArch64 #18578

merged 1 commit into from
Sep 20, 2016

Conversation

yuyichao
Copy link
Contributor

Just noticed that this is a required feature in the A64 state (not available in 32bits ARM) so why not.....

Also fix signature of jl_get_zero_subnormals, i.e. removed unused parameter to match how it is used in ccall.

@yuyichao yuyichao added the system:arm ARMv7 and AArch64 label Sep 19, 2016
@ViralBShah
Copy link
Member

Should this be backported to 0.5?

@yuyichao
Copy link
Contributor Author

yuyichao commented Sep 19, 2016 •
edited
Loading

Up to @tkelman.

The feature addition is a minor one without any API change and is on aarch64 only.
The function signature fix should theoretically be backported to 0.4 where it's added but in practice it shouldn't cause any problem on any platforms we support.

@tkelman
Copy link
Contributor

tkelman commented Sep 19, 2016

Doesn't look like any packages are ccall'ing into it https://github.com/search?q=jl_get_zero_subnormals&type=Code&utf8=%E2%9C%93 so I'd say implementing a feature that already works on other platforms should be fine for backporting.

@yuyichao yuyichao merged commit 1621d7e into master Sep 20, 2016
@yuyichao yuyichao deleted the yyc/arm/denormal branch September 20, 2016 00:40
tkelman pushed a commit that referenced this pull request Feb 22, 2017
@yuyichao @tkelman
Support set/get_zero_subnormals on AArch64. Fix signature of jl_get_z…
a84fdaf 
…ero_subnormals

(cherry picked from commit 9a8001d)
ref #18578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
system:arm ARMv7 and AArch64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuyichao @ViralBShah @tkelman @vtjnash