Kill end_offset
#17543
Merged
Kill end_offset
#17543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
osx segfault during bootstrap is worrying, backed up to https://gist.github.com/bd19ffe481ce192c510bbf987b54b3ff - let's see if it happens again |
yuyichao
force-pushed
the
yyc/gc/no-end-offsets
branch
3 times, most recently
from
f02da5b to
effcb41
Compare
yuyichao
force-pushed
the
yyc/gc/no-end-offsets
branch
from
effcb41 to
71169e0
Compare
We can easily compute if we hits the end of the page in the allocator.
yuyichao
force-pushed
the
yyc/gc/no-end-offsets
branch
from
71169e0 to
272516e
Compare
|
The osx segfault is real and should be fixed. I'm a little surprised that it didn't show up on other CI's though.... Maybe |
|
OK to merge? |
|
It's ready from my perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @JeffBezanson pointed out, we don't need this in the fast path of the allocator. In fact, we don't need this at all since we only use this to figure out if we are at the end of a page and this can be easily computed from the pointer itself.