Make setindex! for sparse matrices and vectors not purge stored entries on zero assignment#17404

Merged

tkelman merged 10 commits intoJuliaLang:masterfrom Sacha0:reworksetindex

Jul 19, 2016

+378-148

Commits on Jul 14, 2016

Rewrite setindex!(A::SparseMatrixCSC, v, i, j) such that it no longer expunges stored entries on zero assignment, throws a more explicit BoundsError when needed, and also for simplicity and clarity…
Sacha0
committed

Commits on Jul 15, 2016

Rework setindex!(A::SparseMatrixCSC, v, I, J) such that it no longer expunges stored entries on zero assignment. Also add tests.
Sacha0
committed
Revise setindex!(A::SparseMatrixCSC, B::SparseMatrixCSC, I, J) such that, when an assigning zero to entry A[i,j], if A[i,j] is not presently stored, the method does not introduce storage for A[i,j]…
Sacha0
committed
Revise setindex!(A::SparseMatrixCSC, x, I::AbstractMatrix{Bool}) such that it no longer expunges stored entries on zero assignment. Also add tests.

KristofferC
authored and
Sacha0
committed
Revise setindex!(A::SparseMatrixCSC, x, I::AbstractVector) such that it no longer expunges stored entries on zero assignment. Also add tests.

KristofferC
authored and
Sacha0
committed
Introduce rudimentary dropstored! methods for dropping stored entries from SparseMatrixCSCs.
Sacha0
committed
Introduce tests for dropstored!(A, i, j) and dropstored!(A, I, J).
Sacha0
committed
Revise setindex!(x::SparseVector, v, i) such that it no longer purges stored entries on zero assignment. Modify tests accordingly.
Sacha0
committed
Introduce rudimentary dropstored! method for dropping entries from SparseVectors. Also introduce associated tests.
Sacha0
committed
Note in NEWS.md that setindex! for sparse matrices and vectors no longer purges allocated entries on zero assignment and that dropstored! now exists to drop stored entries.
Sacha0
committed